Skip to content

Account for unsatisfied bounds in E0599 #84808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2021
Merged

Account for unsatisfied bounds in E0599 #84808

merged 1 commit into from
May 5, 2021

Conversation

estebank
Copy link
Contributor

@estebank estebank commented May 2, 2021

Fix #84769, follow up to #84499, #83667.

@rust-highfive
Copy link
Contributor

r? @petrochenkov

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 2, 2021
@estebank estebank mentioned this pull request May 2, 2021
Closed
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented May 3, 2021

📌 Commit 1e89b58 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 3, 2021
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request May 4, 2021
@Dylan-DPC
Rollup merge of rust-lang#84808 - estebank:issue-84769, r=petrochenkov
eb5ee09 
Account for unsatisfied bounds in E0599

Fix rust-lang#84769, follow up to rust-lang#84499, rust-lang#83667.
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request May 4, 2021
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request May 4, 2021
@Dylan-DPC
Rollup merge of rust-lang#84808 - estebank:issue-84769, r=petrochenkov
337899c 
Account for unsatisfied bounds in E0599

Fix rust-lang#84769, follow up to rust-lang#84499, rust-lang#83667.
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request May 4, 2021
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request May 4, 2021
@Dylan-DPC
Rollup merge of rust-lang#84808 - estebank:issue-84769, r=petrochenkov
5bfedb4 
Account for unsatisfied bounds in E0599

Fix rust-lang#84769, follow up to rust-lang#84499, rust-lang#83667.
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request May 4, 2021
Closed
@pietroalbini pietroalbini added beta-nominated Nominated for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 4, 2021
@pietroalbini
Copy link
Member

pietroalbini commented May 4, 2021 •
edited
Loading

Nominating for beta 1.53.0 backport, this fixes a beta regression.

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request May 4, 2021
@Dylan-DPC
Rollup merge of rust-lang#84808 - estebank:issue-84769, r=petrochenkov
7ac6a01 
Account for unsatisfied bounds in E0599

Fix rust-lang#84769, follow up to rust-lang#84499, rust-lang#83667.
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request May 4, 2021
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request May 4, 2021
@Dylan-DPC
Rollup merge of rust-lang#84808 - estebank:issue-84769, r=petrochenkov
df55085 
Account for unsatisfied bounds in E0599

Fix rust-lang#84769, follow up to rust-lang#84499, rust-lang#83667.
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request May 4, 2021
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request May 4, 2021
@Dylan-DPC
Rollup merge of rust-lang#84808 - estebank:issue-84769, r=petrochenkov
19d0843 
Account for unsatisfied bounds in E0599

Fix rust-lang#84769, follow up to rust-lang#84499, rust-lang#83667.
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request May 4, 2021
Closed
RalfJung added a commit to RalfJung/rust that referenced this pull request May 5, 2021
@RalfJung
Rollup merge of rust-lang#84808 - estebank:issue-84769, r=petrochenkov
92d368b 
Account for unsatisfied bounds in E0599

Fix rust-lang#84769, follow up to rust-lang#84499, rust-lang#83667.
@RalfJung RalfJung mentioned this pull request May 5, 2021
Closed
RalfJung added a commit to RalfJung/rust that referenced this pull request May 5, 2021
@RalfJung
Rollup merge of rust-lang#84808 - estebank:issue-84769, r=petrochenkov
7f7fe25 
Account for unsatisfied bounds in E0599

Fix rust-lang#84769, follow up to rust-lang#84499, rust-lang#83667.
@RalfJung RalfJung mentioned this pull request May 5, 2021
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request May 5, 2021
@Dylan-DPC
Rollup merge of rust-lang#84808 - estebank:issue-84769, r=petrochenkov
bdc7168 
Account for unsatisfied bounds in E0599

Fix rust-lang#84769, follow up to rust-lang#84499, rust-lang#83667.
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request May 5, 2021
Closed
@RalfJung RalfJung mentioned this pull request May 5, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 5, 2021
@bors
Auto merge of rust-lang#84956 - RalfJung:rollup-m70mx2n, r=RalfJung
bacf770 
Rollup of 11 pull requests

Successful merges:

 - rust-lang#83553 (Update `ptr` docs with regards to `ptr::addr_of!`)
 - rust-lang#84183 (Update RELEASES.md for 1.52.0)
 - rust-lang#84709 (Add doc alias for `chdir` to `std::env::set_current_dir`)
 - rust-lang#84803 (Reduce duplication in `impl_dep_tracking_hash` macros)
 - rust-lang#84808 (Account for unsatisfied bounds in E0599)
 - rust-lang#84843 (use else if in std library )
 - rust-lang#84865 (rustbuild: Pass a `threads` flag that works to windows-gnu lld)
 - rust-lang#84878 (Clarify documentation for `[T]::contains`)
 - rust-lang#84882 (platform-support: Center the contents of the `std` and `host` columns)
 - rust-lang#84903 (Remove `rustc_middle::mir::interpret::CheckInAllocMsg::NullPointerTest`)
 - rust-lang#84913 (Do not ICE on invalid const param)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit db77072 into rust-lang:master May 5, 2021
@rustbot rustbot added this to the 1.54.0 milestone May 5, 2021
@workingjubilee workingjubilee mentioned this pull request May 6, 2021
Closed
@apiraino
Copy link
Contributor

apiraino commented May 6, 2021

Beta backport approved as per compiler team on Zulip

@rustbot label +beta-accepted

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label May 6, 2021
@Mark-Simulacrum Mark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label May 13, 2021
@Mark-Simulacrum Mark-Simulacrum modified the milestones: 1.54.0, 1.53.0 May 13, 2021
@estebank estebank deleted the issue-84769 branch November 9, 2023 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@petrochenkov petrochenkov

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.53.0
Development

Successfully merging this pull request may close these issues.

On nightly rustc, E0599 emits a massive diagnostic to suggest wrapping the receiver in every combination of {Box,Pin,Rc,Arc}::new({,&,&mut} expr)
8 participants
@estebank @rust-highfive @petrochenkov @bors @pietroalbini @apiraino @Mark-Simulacrum @rustbot